- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10
 
chore(flight): feedback implementation #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Finishes #149807877
| import supertest from 'supertest'; | ||
| import isEmpty from 'lodash/isEmpty'; | ||
| import app from '../../src/server'; | ||
| import models from '../../server/models'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../server/models'          import/no-unresolved
Missing file extension for "../../server/models"                import/extensions
| import { expect } from 'chai'; | ||
| import supertest from 'supertest'; | ||
| import app from '../../src/server'; | ||
| import models from '../../server/models'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../server/models'  import/no-unresolved
Missing file extension for "../../server/models"        import/extensions
| import supertest from 'supertest'; | ||
| import app from '../../src/server'; | ||
| import models from '../../server/models'; | ||
| import { hashPassword } from '../../server/helpers/helper'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../server/helpers/helper'  import/no-unresolved
Missing file extension for "../../server/helpers/helper"        import/extensions
| import { expect } from 'chai'; | ||
| import supertest from 'supertest'; | ||
| import app from '../../src/server'; | ||
| import models from '../../server/models'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../server/models'          import/no-unresolved
Missing file extension for "../../server/models"                import/extensions
| @@ -0,0 +1,354 @@ | |||
| import { expect } from 'chai'; | |||
| import supertest from 'supertest'; | |||
| import app from '../../src/server'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../src/server'             import/no-unresolved
Missing file extension for "../../src/server"                   import/extensions
| import express from 'express'; | ||
| import { formatDate } from '../helpers/helper'; | ||
| import searchController from '../controllers/search'; | ||
| import { validateQuery } from '../middleware/middleware'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../middleware/middleware'  import/no-unresolved
Missing file extension for "../middleware/middleware"        import/extensions
| @@ -1,102 +1,12 @@ | |||
| import express from 'express'; | |||
| import { formatDate } from '../helpers/helper'; | |||
| import searchController from '../controllers/search'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../controllers/search'     import/no-unresolved
Missing file extension for "../controllers/search"           import/extensions
        
          
                server/routes/roles.js
              
                Outdated
          
        
      | @@ -0,0 +1,15 @@ | |||
| import rolesController from '../controllers/roles'; | |||
| import { authenticate, isAdministrator, validateParam, validateRole } from '../middleware/middleware'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../middleware/middleware'  import/no-unresolved
Missing file extension for "../middleware/middleware"        import/extensions
| @@ -0,0 +1,15 @@ | |||
| import rolesController from '../controllers/roles'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../controllers/roles'      import/no-unresolved
Missing file extension for "../controllers/roles"            import/extensions
| import documentRoutes from './documents'; | ||
| import roleRoutes from './roles'; | ||
| import searchRoutes from './search'; | ||
| import userRoutes from './users'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module './users'      import/no-unresolved
Missing file extension for "./users"            import/extensions
Fixes #149807877
add a helper to generate document/user responses add helper to find document/role/user by id Fixes #149807877
#149807877 feedback implementation