Skip to content

Conversation

@codejockie
Copy link
Owner

Implemented: Allow users save scraped article.

@coveralls
Copy link

coveralls commented Jun 18, 2017

Coverage Status

Coverage decreased (-0.6%) to 90.654% when pulling 6a10f52 on feature/store-scraped-article into b835556 on master.


it('should clear userId and localStorage on logout', () => {
expect(AuthStore.userId).to.equal('');
expect(localStorage.getItem('user')).to.equal(null);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'expect' is not defined no-undef

});

it('should clear userId and localStorage on logout', () => {
expect(AuthStore.userId).to.equal('');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'expect' is not defined no-undef


it('should set user and userId on successful login', () => {
expect(AuthStore.userId).to.equal('1520');
expect(typeof AuthStore.user).to.equal('object');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'expect' is not defined no-undef

});

it('should set user and userId on successful login', () => {
expect(AuthStore.userId).to.equal('1520');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'expect' is not defined no-undef

@@ -0,0 +1,34 @@
import AuthStore from '../../stores/AuthStore.jsx';
import dispatcher from '../../dispatcher.jsx';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../../dispatcher.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../dispatcher.jsx" import/extensions

return (
article ? (
<span>
<Container text textAlign="justified">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow function should not return assignment no-return-assign

import getArticle from '../actions/ArticleActions.jsx';
import { firebaseRef } from '../firebase/index.jsx';
import formatDate from '../helpers/DateFormatter.jsx';
import AuthStore from '../stores/AuthStore.jsx';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected use of file extension "jsx" for "../stores/AuthStore.jsx" import/extensions
Unable to resolve path to module '../stores/AuthStore.jsx' import/no-unresolved


import ArticleStore from '../stores/ArticleStore.jsx';
import getArticle from '../actions/ArticleActions.jsx';
import { firebaseRef } from '../firebase/index.jsx';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to resolve path to module '../firebase/index.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../firebase/index.jsx" import/extensions

import AlertContainer from 'react-alert';
import { hashHistory } from 'react-router';
import { Button, Container, Header, Segment, Divider, Dimmer, Loader } from 'semantic-ui-react';
import { Button, Container, Dimmer, Divider, Header, Loader, Segment } from 'semantic-ui-react';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Button' is defined but never used no-unused-vars
'Container' is defined but never used no-unused-vars
'Dimmer' is defined but never used no-unused-vars
'Divider' is defined but never used no-unused-vars
'Header' is defined but never used no-unused-vars
'Loader' is defined but never used no-unused-vars
'Segment' is defined but never used no-unused-vars
Unable to resolve path to module 'semantic-ui-react' import/no-unresolved
Missing file extension for "semantic-ui-react" import/extensions

@@ -1,12 +1,23 @@
import React, { Component } from 'react';
import AlertContainer from 'react-alert';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'AlertContainer' is defined but never used no-unused-vars
Missing file extension for "react-alert" import/extensions
Unable to resolve path to module 'react-alert' import/no-unresolved

@coveralls
Copy link

Coverage Status

Coverage decreased (-91.2%) to 0.0% when pulling 44b8ac1 on feature/store-scraped-article into b835556 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 90.642% when pulling 44b8ac1 on feature/store-scraped-article into b835556 on master.

@coveralls
Copy link

coveralls commented Jun 18, 2017

Coverage Status

Coverage decreased (-0.6%) to 90.654% when pulling 44b8ac1 on feature/store-scraped-article into b835556 on master.

@codejockie codejockie merged commit f7d6eaa into master Jun 18, 2017
@codejockie codejockie deleted the feature/store-scraped-article branch June 18, 2017 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants