-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/store scraped article #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| it('should clear userId and localStorage on logout', () => { | ||
| expect(AuthStore.userId).to.equal(''); | ||
| expect(localStorage.getItem('user')).to.equal(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'expect' is not defined no-undef
| }); | ||
|
|
||
| it('should clear userId and localStorage on logout', () => { | ||
| expect(AuthStore.userId).to.equal(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'expect' is not defined no-undef
|
|
||
| it('should set user and userId on successful login', () => { | ||
| expect(AuthStore.userId).to.equal('1520'); | ||
| expect(typeof AuthStore.user).to.equal('object'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'expect' is not defined no-undef
| }); | ||
|
|
||
| it('should set user and userId on successful login', () => { | ||
| expect(AuthStore.userId).to.equal('1520'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'expect' is not defined no-undef
| @@ -0,0 +1,34 @@ | |||
| import AuthStore from '../../stores/AuthStore.jsx'; | |||
| import dispatcher from '../../dispatcher.jsx'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../../dispatcher.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../../dispatcher.jsx" import/extensions
| return ( | ||
| article ? ( | ||
| <span> | ||
| <Container text textAlign="justified"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrow function should not return assignment no-return-assign
| import getArticle from '../actions/ArticleActions.jsx'; | ||
| import { firebaseRef } from '../firebase/index.jsx'; | ||
| import formatDate from '../helpers/DateFormatter.jsx'; | ||
| import AuthStore from '../stores/AuthStore.jsx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected use of file extension "jsx" for "../stores/AuthStore.jsx" import/extensions
Unable to resolve path to module '../stores/AuthStore.jsx' import/no-unresolved
|
|
||
| import ArticleStore from '../stores/ArticleStore.jsx'; | ||
| import getArticle from '../actions/ArticleActions.jsx'; | ||
| import { firebaseRef } from '../firebase/index.jsx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to resolve path to module '../firebase/index.jsx' import/no-unresolved
Unexpected use of file extension "jsx" for "../firebase/index.jsx" import/extensions
| import AlertContainer from 'react-alert'; | ||
| import { hashHistory } from 'react-router'; | ||
| import { Button, Container, Header, Segment, Divider, Dimmer, Loader } from 'semantic-ui-react'; | ||
| import { Button, Container, Dimmer, Divider, Header, Loader, Segment } from 'semantic-ui-react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Button' is defined but never used no-unused-vars
'Container' is defined but never used no-unused-vars
'Dimmer' is defined but never used no-unused-vars
'Divider' is defined but never used no-unused-vars
'Header' is defined but never used no-unused-vars
'Loader' is defined but never used no-unused-vars
'Segment' is defined but never used no-unused-vars
Unable to resolve path to module 'semantic-ui-react' import/no-unresolved
Missing file extension for "semantic-ui-react" import/extensions
| @@ -1,12 +1,23 @@ | |||
| import React, { Component } from 'react'; | |||
| import AlertContainer from 'react-alert'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'AlertContainer' is defined but never used no-unused-vars
Missing file extension for "react-alert" import/extensions
Unable to resolve path to module 'react-alert' import/no-unresolved
Implemented: Allow users save scraped article.