Skip to content

Improve logger.debug #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Improve logger.debug #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/main/java/org/codelibs/elasticsearch/df/content/csv/CsvContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@ public CsvContent(final Client client, final RestRequest request, final ContentT
}

if (logger.isDebugEnabled()) {
logger.debug("CsvConfig: " + csvConfig + ", appendHeader: "
+ appendHeader + ", charsetName: " + charsetName
+ ", headerSet: " + headerSet);
logger.debug("CsvConfig: {}, appendHeader: {}, charsetName: {}, headerSet: {}",
csvConfig, appendHeader, charsetName, headerSet);
}
}

Expand Down Expand Up @@ -137,9 +136,8 @@ public void onResponse(final SearchResponse response) {
final int size = hits.getHits().length;
currentCount += size;
if (logger.isDebugEnabled()) {
logger.debug("scrollId: " + scrollId + ", totalHits: "
+ hits.getTotalHits() + ", hits: " + size + ", current: "
+ currentCount);
logger.debug("scrollId: {}, totalHits: {}, hits: {}, current: {}",
scrollId, hits.getTotalHits(), size, currentCount);
}
try {
for (final SearchHit hit : hits) {
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/org/codelibs/elasticsearch/df/content/json/JsonContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,8 @@ public void onResponse(final SearchResponse response) {
final int size = hits.getHits().length;
currentCount += size;
if (logger.isDebugEnabled()) {
logger.debug("scrollId: " + scrollId + ", totalHits: "
+ hits.getTotalHits() + ", hits: " + size + ", current: "
+ currentCount);
logger.debug("scrollId: {}, totalHits: {}, hits: {}, current: {}",
scrollId, hits.getTotalHits(), size, currentCount);
}
try {
for (final SearchHit hit : hits) {
Expand Down
9 changes: 4 additions & 5 deletions src/main/java/org/codelibs/elasticsearch/df/content/xls/XlsContent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ public XlsContent(final Client client, final RestRequest request, final ContentT
this.isExcel2007 = isExcel2007;

if (logger.isDebugEnabled()) {
logger.debug("appendHeader: " + appendHeader + ", headerSet: "
+ headerSet + ", isExcel2007: " + isExcel2007);
logger.debug("appendHeader: {}, headerSet: {}, isExcel2007: {}",
appendHeader, headerSet, isExcel2007);
}
}

Expand Down Expand Up @@ -150,9 +150,8 @@ public void onResponse(final SearchResponse response) {

final int size = hits.getHits().length;
if (logger.isDebugEnabled()) {
logger.debug("scrollId: " + scrollId + ", totalHits: "
+ hits.getTotalHits() + ", hits: " + size
+ ", current: " + (currentRowNumber + size));
logger.debug("scrollId: {}, totalHits: {}, hits: {}, current: {}",
scrollId, hits.getTotalHits(), size, (currentRowNumber + size));
}
for (final SearchHit hit : hits) {
final Map<String, Object> sourceMap = hit.getSourceAsMap();
Expand Down