[vim keymap] Add actionArgs for command 'i' 'I'#1525
Closed
lynschinzer wants to merge 2 commits intocodemirror:masterfrom
Closed
[vim keymap] Add actionArgs for command 'i' 'I'#1525lynschinzer wants to merge 2 commits intocodemirror:masterfrom
lynschinzer wants to merge 2 commits intocodemirror:masterfrom
Conversation
Contributor
|
Looks good. Nit: in general, prefer |
Contributor
Author
After viewing the benchmarks from I kinda agree with you. |
Contributor
Author
|
That should do it. |
Contributor
|
Looks good. Thanks. |
marijnh
added a commit
that referenced
this pull request
May 14, 2013
Member
|
Merged. Stray character removed in attached patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is responding to the received suggestions from #1521.
actionArgs.insertAtcan be later used for recording cursor behaviors for latestenterInsertModecommands.