Add beforeHistoryChange event#1539
Closed
aslushnikov wants to merge 2 commits intocodemirror:masterfrom
Closed
Conversation
Intent: it is useful to get notifications about future changes of the document so that one might be able to update his own external document representation on an incremental basis. This event is complimentary to the "beforeChange" event which may be used for this purpose but which doesn't fire for the undo/redo commands.
Member
|
This is a good idea. But how about moving the |
Contributor
Author
|
Do you mean smth like this? |
marijnh
added a commit
that referenced
this pull request
May 24, 2013
But disable its update method in that case. Issue #1539
Member
|
Yes, though -- sorry to waste your time -- I decided that actually that's not what I want either. I've pushed a different change (see attached patch) where Does that work for you? |
Contributor
Author
|
That works for me, thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent: the event is useful to get notifications about
future changes of the document so that one might be able
to update his own external document representation on an incremental
basis. This event is complimentary to the "beforeChange" event which
may be used for this purpose but which doesn't fire for the undo/redo
commands.