Skip to content

Add bower.json file for full bower compatibility.#1540

Closed
danheberden wants to merge 1 commit intocodemirror:masterfrom
danheberden:issue_1540
Closed

Add bower.json file for full bower compatibility.#1540
danheberden wants to merge 1 commit intocodemirror:masterfrom
danheberden:issue_1540

Conversation

@danheberden
Copy link
Copy Markdown
Contributor

No description provided.

@marijnh
Copy link
Copy Markdown
Member

marijnh commented May 22, 2013

Oh joy, another file that I have to bump version numbers in. Is the version field obligatory, or can we get the tool to just look at package.json?

@danheberden
Copy link
Copy Markdown
Contributor Author

Oh, we're gonna ditch version unless the repo doesn't have a tag - so as long as you tag your repo as vX.X.X or X.X.X (which it looks like you started doing with 3.13.0), you don't need to worry about it.

marijnh added a commit that referenced this pull request May 22, 2013
@marijnh
Copy link
Copy Markdown
Member

marijnh commented May 22, 2013

Great. Merged. Version field removed in attached patch.

@marijnh marijnh closed this May 22, 2013
@danheberden
Copy link
Copy Markdown
Contributor Author

I wouldn't remove the version yet - we need to update bower to use the new spec implementation. I just wouldn't worry about updating it for now, if you don't mind.

@marijnh
Copy link
Copy Markdown
Member

marijnh commented May 22, 2013

Okay, reverted.

@danheberden
Copy link
Copy Markdown
Contributor Author

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants