Fix indentation of javascript statements under multi-line statement bloc...#1553
Closed
chandrap wants to merge 1 commit intocodemirror:masterfrom
Closed
Fix indentation of javascript statements under multi-line statement bloc...#1553chandrap wants to merge 1 commit intocodemirror:masterfrom
chandrap wants to merge 1 commit intocodemirror:masterfrom
Conversation
…lock. Let me know your opinion on this fix. https://groups.google.com/forum/#!topic/codemirror/wXQm2H0ACyA/discussion myproj.blah.blah.enterDocument = function() { <== 4-space multi-line statement block. goog.base(this, 'enterDocument'); // <== expected 2-space indentation. goog.base(this, 'enterDocument'); // <== actual/incorrect 6-space indentation.
marijnh
added a commit
that referenced
this pull request
Jun 6, 2013
Member
anaran
pushed a commit
to anaran/CodeMirror
that referenced
this pull request
Feb 22, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...k.
Let me know your opinion on this fix.
https://groups.google.com/forum/#!topic/codemirror/wXQm2H0ACyA/discussion
myproj.blah.blah.enterDocument =
function() { <== 4-space multi-line statement block.
goog.base(this, 'enterDocument'); // <== expected 2-space indentation.
goog.base(this, 'enterDocument'); // <== actual/incorrect 6-space indentation.