Export visibleLines to public api#1556
Closed
aslushnikov wants to merge 1 commit intocodemirror:masterfrom
Closed
Conversation
marijnh
added a commit
that referenced
this pull request
May 30, 2013
Member
|
Please see my attached patch instead -- I guess a general way to cheaply find the line at a given y offset would be more generally useful, and less 'random exposed internals'-y. |
Contributor
Author
|
Does the |
Member
|
No, it returns the first line -- i.e. the line at offset 0. "local" coordinates are not scroll-sensitive.
|
Contributor
Author
|
Thanks, that works. |
anaran
pushed a commit
to anaran/CodeMirror
that referenced
this pull request
Feb 22, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The only way to figure out a first visible line number (or a bottom visible line number)
is to call
codeMirror.coordsChar({left: 0, top: 0}, "local"). (please correct me if I'm wrong).The problem is, however, that this method is pretty expensive because of a
measureLineInnercall, so in case of calling it multiple times in ascrollevent handler on a file with multiple long lines - scrolling gets laggy.The
visibleLinesmethod seems to be a natural solution for the problem.