[css] Fix indentation issue in SCSS mode with mixin variables (for #1846)#1851
Closed
0b10011 wants to merge 2 commits intocodemirror:masterfrom
Closed
[css] Fix indentation issue in SCSS mode with mixin variables (for #1846)#18510b10011 wants to merge 2 commits intocodemirror:masterfrom
0b10011 wants to merge 2 commits intocodemirror:masterfrom
Conversation
…odemirror#1846). Also improve handling of parentheses and curly braces.
Member
|
Thanks! Merged. Try to configure your editor to not use tabs for indentation, next time. |
Contributor
Author
|
Gah, sorry about that. I was working on a new machine that I don't have configured yet and thought I'd be able to fix them manually before I sent it off to you. Looks like I missed a few. Will do for next time! |
anaran
pushed a commit
to anaran/CodeMirror
that referenced
this pull request
Feb 22, 2014
Kill all tabs. Issue codemirror#1851
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue in #1846 and auto-resets the indentation level when parentheses and curly braces are present, which should help indentation issues be less bothersome when an issue does present itself in a block.
In the second commit I modified the mode testing code a bit to allow for testing indentation, and added a couple small tests for CSS/SCSS modes. This should help to avoid regressions in the future. But, as usual, feel free to alter, add to, or ignore the second commit.