Skip to content

Introduce a new configurable option that allows to customize text selection#1857

Closed
janodvarko wants to merge 2 commits intocodemirror:masterfrom
janodvarko:reset-selection
Closed

Introduce a new configurable option that allows to customize text selection#1857
janodvarko wants to merge 2 commits intocodemirror:masterfrom
janodvarko:reset-selection

Conversation

@janodvarko
Copy link
Copy Markdown
Contributor

Right clicking within CodeMirror editor, but outside of an existing selected text clears the selection.

This pull request introduces a new option that allows to customize the behavior.

Not sure about the option name. Any better suggestions?

See also this thread:
https://groups.google.com/forum/#!topic/codemirror/kzy1oGnmhBI

Honza

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a little odd -- in that you added a conditional reset, but left the other one (below) intact. I don't see how this will prevent the reset from taking place.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry (a typo), fixed!

Honza

@fflorent
Copy link
Copy Markdown

fflorent commented Oct 8, 2013

Hi,
Is the last commit okay?

Florent

marijnh added a commit that referenced this pull request Oct 8, 2013
@marijnh
Copy link
Copy Markdown
Member

marijnh commented Oct 8, 2013

I lost track of this. Thanks for reminding me. Merged as 9ebe46e , documentation added in attached patch.

@marijnh marijnh closed this Oct 8, 2013
@fflorent
Copy link
Copy Markdown

fflorent commented Oct 8, 2013

Do you have any date (or idea of date) for the next release?

Florent

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Oct 8, 2013

Releases come around the 20th of each month, but you can also simply use a development snapshot.

@fflorent
Copy link
Copy Markdown

fflorent commented Oct 8, 2013

Okay, nice! Thanks!

Florent

anaran pushed a commit to anaran/CodeMirror that referenced this pull request Feb 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants