auto expand folded regions when fold ranges become invalid#2581
Closed
thehogfather wants to merge 2 commits intocodemirror:masterfrom
Closed
auto expand folded regions when fold ranges become invalid#2581thehogfather wants to merge 2 commits intocodemirror:masterfrom
thehogfather wants to merge 2 commits intocodemirror:masterfrom
Conversation
Member
|
I am not sure how I failed to respond to this. Apologies for that. I think a more lightweight solution is to fix the unfold markers so that they work even if the foldable range is no longer there. Attached patch does this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue where fold markers do nothing if a folded region is made invalid as a result of an undo or delete action. To reproduce:
Result is that the fold marker no longer expands the folded region, although one is still able to click text marker or indeed expand the fold by navigating the cursor into the region.
In an attempt to address this issue, this pull request expands a folded region when they become invalid.
Credits to @JeffryBooher for spotting the issue.