Added the possibility to automatically jump to first diff ocurrence#2858
Closed
plafue wants to merge 9 commits intocodemirror:masterfrom
Closed
Added the possibility to automatically jump to first diff ocurrence#2858plafue wants to merge 9 commits intocodemirror:masterfrom
plafue wants to merge 9 commits intocodemirror:masterfrom
Conversation
…hen the editor is loaded.
…hen the editor is loaded.
…or into jump_to_first_difference
…or into jump_to_first_difference
…or into jump_to_first_difference
Member
|
I think a much better API would be to simply expose a method |
Member
|
You should add a comment when you add patches -- otherwise, I won't notice them. Anyway, your implementation still isn't really what I was looking for. See my attached patch for an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merge addon now can jump to the first difference if configured so. I'm not quite happy with the hard coded 8 in line 64, maybe someone has a tip how to easily get the font size of the editor?