Skip to content

moved colorforth to theme folder; minor fix to demo page#3053

Closed
drom wants to merge 9 commits intocodemirror:masterfrom
drom:master
Closed

moved colorforth to theme folder; minor fix to demo page#3053
drom wants to merge 9 commits intocodemirror:masterfrom
drom:master

Conversation

@drom
Copy link
Copy Markdown
Contributor

@drom drom commented Jan 28, 2015

No description provided.

@drom
Copy link
Copy Markdown
Contributor Author

drom commented Jan 28, 2015

There are some historical (cultural) reasons behind creating of this colorforth theme for Forth mode.
I hope to get some involvement form Forth community by doing so. Here is the blog about it:
http://blogs.msdn.com/b/ashleyf/archive/2013/11/02/colorforth.aspx

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Jan 29, 2015

I am actually aware of colorforth (I did have a Forth phase a long time ago), but I don't believe that the lack of contrast in this theme are necessary for a colorforth look -- grey text on slightly darker grey background is a bad idea in any context. If you can (significantly) up the contrast, either by darkening the background or brightening the text (or even both), I'll be happy to merge this in.

@drom
Copy link
Copy Markdown
Contributor Author

drom commented Jan 30, 2015

You are right, It is not very good contrast. I have tweaked some colors. Does it look better?

snapshot13

These are the brightest Red, Green, Yellow I can get.
I would like to keep different background for compilation and interpretation time.

marijnh added a commit that referenced this pull request Jan 30, 2015
@marijnh
Copy link
Copy Markdown
Member

marijnh commented Jan 30, 2015

Thanks. Merged as 41a740b. Next time, please try to rebase your pull request branch, rather than leaving in merge commits, so that it is easier for me to pick out the relevant patches.

@marijnh marijnh closed this Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants