[css mode] teach it about CSS variables#3064
Closed
KwanEsq wants to merge 1 commit intocodemirror:masterfrom
Closed
[css mode] teach it about CSS variables#3064KwanEsq wants to merge 1 commit intocodemirror:masterfrom
KwanEsq wants to merge 1 commit intocodemirror:masterfrom
Conversation
marijnh
added a commit
that referenced
this pull request
Feb 2, 2015
Member
Contributor
Author
|
Great, thanks! Apologies for the lack of a test, I didn't immediately grok your test syntax, and figured if you wanted one you would let me know. I'm attempting to write one for #3065, though not sure if I'm doing it correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CSS variables e.g. --main-color not only fail to highlight properly, but also screw up the parsing later in the document, so auto-indenting fails. (It indents an extra step after using a variable in var(), and sometimes un-indents a step after declaring the variable).
This fixes both of these problems by correctly parsing occurrences of --variable-name
Tests run locally, all pass.