Support advance properteis for sql hint#3095
Closed
gzzhanghao wants to merge 1 commit intocodemirror:masterfrom
Closed
Support advance properteis for sql hint#3095gzzhanghao wants to merge 1 commit intocodemirror:masterfrom
gzzhanghao wants to merge 1 commit intocodemirror:masterfrom
Conversation
Member
|
You are changing the table format in an incompatible, breaking way. That is not acceptable. |
Contributor
Author
|
@marijnh The patch is backward compatible, the original table format is supported as well. |
marijnh
added a commit
that referenced
this pull request
Feb 20, 2015
Member
prathik457
reviewed
Aug 30, 2018
| if (typeof item == 'string') { | ||
| return item; | ||
| } | ||
| return item.text; |
There was a problem hiding this comment.
Shouldn't this be item.displayText?
Let's suppose I have a table object {columns:{....}, text: '{{table1}}', displayText:'table1'}
Then when I type 'ta' it does not return me anything. Am I missing something?
Member
There was a problem hiding this comment.
Shouldn't this be item.displayText?
No, this is used to get the actual completion text, not the label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for advance properties (
displayTextfor example) for sql-hint addon.Here is an example for the new feature: