Skip to content

[stylus mode] New version#3138

Closed
dmitrykiselyov wants to merge 4 commits intocodemirror:masterfrom
dmitrykiselyov:master
Closed

[stylus mode] New version#3138
dmitrykiselyov wants to merge 4 commits intocodemirror:masterfrom
dmitrykiselyov:master

Conversation

@dmitrykiselyov
Copy link
Copy Markdown
Contributor

Better auto-indent and highlighting.

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Mar 18, 2015

I've merged this as fc2def3 and 866934b

Next time, please start from my version of the code, instead of simply continuing on your own old branch. That makes it easier for me to merge, and makes sure you actually get the code I merged. I've made a bunch of adjustments to code style, and made the linter pass. I'm not going to do that a 3rd time for this code.

@marijnh marijnh closed this Mar 18, 2015
marijnh added a commit that referenced this pull request Mar 18, 2015
@dmitrykiselyov
Copy link
Copy Markdown
Contributor Author

Ok. Thanks for the adjustments to code style. How to run bin/lint?
I'll improve my knowledge of git and the next pull request will be shine ✨

@marijnh
Copy link
Copy Markdown
Member

marijnh commented Mar 20, 2015

You need to install node, then run npm install in the CodeMirror directory, and then bin/lint should run.

@dmitrykiselyov
Copy link
Copy Markdown
Contributor Author

Thanks 👍
I think that with the $ sign ($ bin/lint) will be more obvious for Windows users 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants