[markdown mode] Fix inappropiate behavior of continuelist addon#3178
Closed
marcelgerber wants to merge 2 commits intocodemirror:masterfrom
Closed
[markdown mode] Fix inappropiate behavior of continuelist addon#3178marcelgerber wants to merge 2 commits intocodemirror:masterfrom
marcelgerber wants to merge 2 commits intocodemirror:masterfrom
Conversation
Member
|
I think my patch is less invasive, but if it misses something your patch solves, let me know. |
Contributor
Author
|
I just noticed |
Member
|
Ah, you are entirely right. I didn't expect an unrelated patch in the pull request, and completely misinterpreted the code. I've merged your solution instead, as well as your cleanup patch. |
Contributor
Author
|
Well, I don't exactly know why, but this fix (and yeah, to be honest, it looks pretty unrelated) fixed the issue for me! |
Contributor
Author
|
For little more background: Thus, it should still work after you revert your unneeded commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
- --(which is a horizontal ruler)Result:
Expected:
- --The issue was that
state.quote, a numeric value, was compared tofalse.I also improved the markdown mode a tiny bit.