Also split and clean sbt files in plugin dev environment

#124

93ddc3f has done this for the main repo

Author: hlxid

build/src/main/scala/org/codeoverflow/chatoverflow/build/SbtFile.scala

@@ -3,7 +3,6 @@ package org.codeoverflow.chatoverflow.build
 import java.io.{BufferedWriter, File, FileWriter, IOException}
 
 import org.codeoverflow.chatoverflow.build.plugins.Plugin
-import sbt.librarymanagement.{CrossVersion, ModuleID}
 
 /**
  * Represents a simple sbt files content and methods to create a new sbt file. Not intended to open/read sbt files.
@@ -13,30 +12,22 @@ import sbt.librarymanagement.{CrossVersion, ModuleID}
  * @param plugins        list of paths of sub projects
  * @param apiProjectPath the path of a base api project which every project depends on
  * @param defineRoot     true, if a root project (".") should be defined in the sbt file
- * @param dependencies   library dependencies to add to the sbt file
  */
 class SbtFile(val name: String, val version: String, val plugins: List[Plugin], val apiProjectPath: String,
-              val defineRoot: Boolean, dependencies: List[ModuleID]) {
+              val defineRoot: Boolean) {
   /**
    * Represents a simple sbt files content and methods to create a new sbt file. Not intended to open/read sbt files.
    *
    * @param name    the name of a sbt project
    * @param version the version of a sbt project
    */
-  def this(name: String, version: String) = this(name, version, List(), "", false, List())
+  def this(name: String, version: String) = this(name, version, List(), "", false)
 
   /**
    * Represents a simple sbt files content and methods to create a new sbt file. Not intended to open/read sbt files.
    */
   def this() = this("", "")
 
-  /**
-   * Represents a simple sbt files content and methods to create a new sbt file. Not intended to open/read sbt files.
-   *
-   * @param dependencies library dependencies to add to the sbt file
-   */
-  def this(dependencies: List[ModuleID]) = this("", "", List(), "", false, dependencies)
-
   /**
    * Tries to save the sbt files content into a defined directory.
    *
@@ -101,32 +92,6 @@ class SbtFile(val name: String, val version: String, val plugins: List[Plugin],
       sbtContent append rootLine
     }
 
-    if (dependencies.nonEmpty) {
-      sbtContent append "\nresolvers += \"jcenter-bintray\" at \"https://jcenter.bintray.com\"\n"
-
-      val depString = dependencies.map(m => renderModuleID(m)).mkString("  ", ",\n  ", "")
-
-      sbtContent append s"libraryDependencies ++= Seq(\n$depString\n)\n"
-    }
-
     sbtContent.mkString
   }
-
-  /**
-   * Converts a ModuleID instance to a string with the module in the syntax that is used in sbt files.
-   */
-  private def renderModuleID(m: ModuleID): String = {
-    var formatString = ""
-
-    // Note that the %% in the string are required to escape the string formatter and will turn into a single %
-    if (m.crossVersion == CrossVersion.binary)
-      formatString += "\"%s\" %%%% \"%s\" %% \"%s\""
-    else
-      formatString += "\"%s\" %% \"%s\" %% \"%s\""
-
-    if (m.configurations.isDefined)
-      formatString += " %% \"%s\""
-
-    formatString.format(m.organization, m.name, m.revision, m.configurations.getOrElse(""))
-  }
 }

build/src/main/scala/org/codeoverflow/chatoverflow/build/deployment/DeploymentUtility.scala

@@ -4,9 +4,7 @@ import java.io.File
 import java.nio.file.{Files, Paths}
 
 import org.codeoverflow.chatoverflow.build.BuildUtils.withTaskInfo
-import org.codeoverflow.chatoverflow.build.SbtFile
 import sbt.internal.util.ManagedLogger
-import sbt.librarymanagement.ModuleID
 
 /**
  * Holds the functionality to create end-user and plugin dev deployments.
@@ -59,9 +57,8 @@ object DeploymentUtility {
    * @param logger              the sbt logger
    * @param scalaLibraryVersion the scala library major version
    * @param apiProjectPath      the path to the api project. Used to copy the api into the deployDev directory
-   * @param dependencies        the dependencies of the framework. Used to create a sbt file with them.
    */
-  def prepareDevDeploymentTask(logger: ManagedLogger, scalaLibraryVersion: String, apiProjectPath: String, dependencies: List[ModuleID]): Unit = {
+  def prepareDevDeploymentTask(logger: ManagedLogger, scalaLibraryVersion: String, apiProjectPath: String): Unit = {
     // Assuming, before this: clean, gui, package and buildProject/package
     // Assuming: Hardcoded "bin/", "deployDev/", "launcher/" and "build/" folders
     // Assuming: A folder called "launcher/deployment-files/plugin-dev/" with more additional files for plugin developers
@@ -85,9 +82,8 @@ object DeploymentUtility {
       sbt.IO.copyDirectory(new File(apiProjectPath), new File("deployDev/api/"))
       sbt.IO.delete(new File("deployDev/api/target")) // otherwise compiled code would end up in the zip
 
-      // Fourth step: Create sbt files containing all dependencies
-      val depFile = new SbtFile(dependencies)
-      sbt.IO.write(new File("deployDev/dependencies.sbt"), depFile.toString)
+      // Fourth step: Copy sbt file containing dependencies
+      sbt.IO.copyFile(new File("dependencies.sbt"), new File("deployDev/dependencies.sbt"))
 
       // Last step: Copy additional files
       val devDeploymentFiles = new File("launcher/deployment-files/plugin-dev/")

keys.sbt

@@ -38,7 +38,7 @@ copy := new PluginUtility(streams.value.log).copyPluginsTask(pluginFolderNames.v
 deploy := DeploymentUtility.prepareDeploymentTask(streams.value.log,
   scalaVersion.value.split('.').dropRight(1).mkString("."))
 deployDev := DeploymentUtility.prepareDevDeploymentTask(streams.value.log,
-  scalaVersion.value.split('.').dropRight(1).mkString("."), apiProjectPath.value, libraryDependencies.value.toList)
+  scalaVersion.value.split('.').dropRight(1).mkString("."), apiProjectPath.value)
 gui := new GUIUtility(streams.value.log).guiTask(guiProjectPath.value, streams.value.cacheDirectory / "gui")