Skip to content

Conversation

@ppiech
Copy link

@ppiech ppiech commented Dec 15, 2015

I'd like to add more content to the dagger 2 write up, including these diagrams for reference.

@nesquena
Copy link
Member

@rogerhu

@ppiech
Copy link
Author

ppiech commented Dec 15, 2015

Not sure if i'm breaking any etiquette in this project, but I started updating the wiki doc for dagger as well.

@nesquena
Copy link
Member

No etiquette broken, please feel free to improve any of the guides as you see fit :)

nesquena added a commit that referenced this pull request Dec 15, 2015
@nesquena nesquena merged commit bc69267 into codepath:master Dec 15, 2015
@nesquena
Copy link
Member

I've merged your diagrams as well, feel free to include them in the guide to help illustrate how it works. We definitely need help reviewing our Dagger 2 guide.

@rogerhu
Copy link
Member

rogerhu commented Dec 15, 2015

Feel free to review and edit...although do you think the diagrams actually
make things clearer? It seems at the very least they need explanation.
On Dec 15, 2015 12:02 PM, "Nathan Esquenazi" notifications@github.com
wrote:

I've merged your diagrams as well, feel free to include them in the guide
to help illustrate how it works. We definitely need help reviewing our
Dagger 2 guide.


Reply to this email directly or view it on GitHub
#124 (comment)
.

@ppiech
Copy link
Author

ppiech commented Dec 15, 2015

Many thanks for the quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants