Skip to content

Trim whitespace from IP address inputs to prevent SSH connection failures #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Trim whitespace from IP address inputs to prevent SSH connection failures #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dokploy/components/dashboard/settings/servers/handle-servers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export const HandleServers = ({ serverId }: Props) => {
await mutateAsync({
name: data.name,
description: data.description || "",
ipAddress: data.ipAddress || "",
ipAddress: data.ipAddress?.trim() || "",
port: data.port || 22,
username: data.username || "root",
sshKeyId: data.sshKeyId || "",
Expand Down
2 changes: 1 addition & 1 deletion apps/dokploy/components/dashboard/settings/servers/welcome-stripe/create-server.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export const CreateServer = ({ stepper }: Props) => {
await mutateAsync({
name: data.name,
description: data.description || "",
ipAddress: data.ipAddress || "",
ipAddress: data.ipAddress?.trim() || "",
port: data.port || 22,
username: data.username || "root",
sshKeyId: data.sshKeyId || "",
Expand Down
4 changes: 2 additions & 2 deletions apps/dokploy/components/dashboard/settings/web-server/update-server-ip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { toast } from "sonner";
import { z } from "zod";

const schema = z.object({
serverIp: z.string(),
serverIp: z.string().trim(),
});

type Schema = z.infer<typeof schema>;
Expand Down Expand Up @@ -76,7 +76,7 @@ export const UpdateServerIp = ({ children }: Props) => {

const onSubmit = async (data: Schema) => {
await mutateAsync({
serverIp: data.serverIp,
serverIp: data.serverIp.trim(),
})
.then(async () => {
toast.success("Server IP Updated");
Expand Down
1 change: 1 addition & 0 deletions packages/server/src/db/schema/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ const createSchema = createInsertSchema(server, {
serverId: z.string().min(1),
name: z.string().min(1),
description: z.string().optional(),
ipAddress: z.string().trim(),
});

export const apiCreateServer = createSchema
Expand Down