Skip to content

feat(TagsList): sort tags alphabetically and update related logic #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(TagsList): sort tags alphabetically and update related logic #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,5 @@ docker/*local*
test-report.html
superset/static/stats/statistics.html
.aider*

.cursor
25 changes: 16 additions & 9 deletions superset-frontend/src/components/Tags/TagsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,29 @@ const TagsList = ({

const collapse = () => setTempMaxTags(maxTags);

// Sort tags alphabetically by name (case-insensitive) with memoization
const sortedTags = useMemo(() => {
return [...tags].sort((a, b) =>
a.name.toLowerCase().localeCompare(b.name.toLowerCase())
);
}, [tags]);

const tagsIsLong: boolean | null = useMemo(
() => (tempMaxTags ? tags.length > tempMaxTags : null),
[tags.length, tempMaxTags],
() => (tempMaxTags ? sortedTags.length > tempMaxTags : null),
[sortedTags.length, tempMaxTags],
);

const extraTags: number | null = useMemo(
() =>
typeof tempMaxTags === 'number' ? tags.length - tempMaxTags + 1 : null,
[tagsIsLong, tags.length, tempMaxTags],
typeof tempMaxTags === 'number' ? sortedTags.length - tempMaxTags + 1 : null,
[tagsIsLong, sortedTags.length, tempMaxTags],
);

return (
<TagsDiv className="tag-list">
{tagsIsLong && typeof tempMaxTags === 'number' ? (
<>
{tags.slice(0, tempMaxTags - 1).map((tag: TagType, index) => (
{sortedTags.slice(0, tempMaxTags - 1).map((tag: TagType, index) => (
<Tag
id={tag.id}
key={tag.id}
Expand All @@ -82,17 +89,17 @@ const TagsList = ({
editable={editable}
/>
))}
{tags.length > tempMaxTags ? (
{sortedTags.length > tempMaxTags ? (
<Tag
name={`+${extraTags}...`}
onClick={expand}
toolTipTitle={tags.map(t => t.name).join(', ')}
toolTipTitle={sortedTags.map(t => t.name).join(', ')}
/>
) : null}
</>
) : (
<>
{tags.map((tag: TagType, index) => (
{sortedTags.map((tag: TagType, index) => (
<Tag
id={tag.id}
key={tag.id}
Expand All @@ -103,7 +110,7 @@ const TagsList = ({
/>
))}
{maxTags ? (
tags.length > maxTags ? (
sortedTags.length > maxTags ? (
<Tag name="..." onClick={collapse} />
) : null
) : null}
Expand Down