fix(plugin-chart-table): improve orderby logic and add tests for orde… #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(plugin-chart-table): align order controls with UX expectations
order_desccheckbox directly undertimeseries_limit_metric.order_descunless a sort metric is selected in aggregate mode.buildQueryfallback ordering to respect the Sort Descending toggle.SUMMARY
The table chart’s sort controls now reflect their dependency: the Sort Descending checkbox sits under Sort Query By and is only rendered when a metric is selected (and we’re in aggregation mode). When no explicit sort metric is chosen,
buildQuerynow honors the user’s Sort Descending preference instead of always sorting descending. Added targeted Jest tests to cover both UI visibility and fallback ordering.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Sort Descending always visible below pagination controls, independent of any selected metric, and fallback ordering ignored the toggle.
After: Checkbox appears directly under Sort Query By only when applicable, and default ordering flips based on the toggle even without an explicit sort metric.
TESTING INSTRUCTIONS
npm run test -- plugin-chart-table/test/controlPanel.test.tsnpm run test -- plugin-chart-table/test/buildQuery.test.tsADDITIONAL INFORMATION