Fix use-after-free of IMGDNN network outputs. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroy imgdnn_memory for network outputs in ANeuralNetworkExecution_notifyWait after they are unlocked, instead of at the end of ANeuralNetworksExecution_startCompute. Fixes "CL: Invalid memory object" errors in test_serialize and test_binary.
Rbiessy
approved these changes
Feb 6, 2020
Contributor
Rbiessy
left a comment
Rbiessy
left a comment
There was a problem hiding this comment.
Of course, thank you for the fix!
Co-Authored-By: Romain Biessy <romain.biessy@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroy imgdnn_memory for network outputs in
ANeuralNetworkExecution_notifyWait after they are unlocked, instead of
at the end of ANeuralNetworksExecution_startCompute.
Fixes "CL: Invalid memory object" errors in test_serialize and
test_binary.