work-item strided transforms #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AD2605
reviewed
Jan 31, 2024
FMarno
force-pushed
the
finlay/strided
branch
from
bcd28b7 to
bee6505
Compare
t4c1
requested changes
Feb 1, 2024
FMarno
force-pushed
the
finlay/strided
branch
from
8c8393d to
bbdeb82
Compare
Rbiessy
reviewed
Feb 5, 2024
FMarno
force-pushed
the
finlay/strided
branch
from
471f48c to
cdf802c
Compare
Rbiessy
reviewed
Feb 6, 2024
FMarno
force-pushed
the
finlay/strided
branch
from
f3609cf to
fd9d7cc
Compare
Rbiessy
approved these changes
Feb 8, 2024
AD2605
approved these changes
Feb 9, 2024
t4c1
approved these changes
Feb 9, 2024
Contributor
t4c1
left a comment
t4c1
left a comment
There was a problem hiding this comment.
assuming addressing other comments did not break anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds work-item level strided ffts.
This includes support for arbitrary strides and distances for 1D transforms, layout validation, and validation tests.
Checklist
Tick if relevant: