Skip to content

fix: inject MCP tools with stable order #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2025
Merged

fix: inject MCP tools with stable order #49

merged 4 commits into from
Nov 12, 2025
+222 −7

Conversation

@dannykopping
Copy link
Collaborator

@dannykopping dannykopping commented Nov 11, 2025 •
edited
Loading

The order of the injected MCP tools was always changing, which busted the cache.

Before:

  ⎿ Total cost:            $0.58                                   
    Total code changes:    357 lines added, 0 lines removed        
    Usage by model:                                                      
           claude-sonnet:  39 input, 5.0k output, 109.3k cache     
    read, 125.2k cache write ($0.58)    <-- note the high cache writes

After:

  ⎿  Total cost:            $0.1691
     Total code changes:    336 lines added, 0 lines removed
     Usage by model:
            claude-sonnet:  21 input, 4.4k output, 130.9k cache
     read, 15.0k cache write ($0.1616)

@dannykopping
fix: stable injected tools order
66dd867 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping requested a review from pawbana November 11, 2025 14:53
@dannykopping dannykopping self-assigned this Nov 11, 2025
ibetitsmike
ibetitsmike reviewed Nov 11, 2025
View reviewed changes
@dannykopping
fix: use ID not Name
a1bb858 
Signed-off-by: Danny Kopping <danny@coder.com>
ibetitsmike
ibetitsmike reviewed Nov 11, 2025
View reviewed changes
@dannykopping
fix: improve tests
0439a24 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping
chore: add test to ensure outbound request is stably encoded
f043195 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping merged commit cc9fa29 into main Nov 12, 2025
dannykopping added a commit that referenced this pull request Nov 12, 2025
@dannykopping
fix: inject MCP tools with stable order (#49)
5899d51 
Signed-off-by: Danny Kopping <danny@coder.com>
@dannykopping dannykopping mentioned this pull request Nov 12, 2025
Merged
dannykopping added a commit to coder/coder that referenced this pull request Nov 12, 2025
@dannykopping
fix: upgrade aibridge lib to fix cache issue (#20730)
d495450 
coder/aibridge#49 fixed an issue with tool
ordering which was busting the cache and leading to increased costs

Signed-off-by: Danny Kopping <danny@coder.com>
dannykopping added a commit to coder/coder that referenced this pull request Nov 12, 2025
@dannykopping
fix: upgrade aibridge lib to fix cache issue (#20730)
f1cb5c2 
coder/aibridge#49 fixed an issue with tool
ordering which was busting the cache and leading to increased costs

Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ibetitsmike ibetitsmike ibetitsmike approved these changes

@pawbana pawbana Awaiting requested review from pawbana

Assignees

@dannykopping dannykopping

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dannykopping @ibetitsmike