Skip to content

fix: reset terminal properly on resize in blink dev #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
Merged

fix: reset terminal properly on resize in blink dev #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7749b
fix: use unique keys for message components
hugodutka Oct 24, 2025
b1c79c1
fix: reset terminal on resize properly
hugodutka Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bun.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"@types/ws": "^8.18.1",
"@whatwg-node/server": "^0.10.12",
"@xterm/headless": "^5.5.0",
"ansi-escapes": "^7.1.1",
"chalk": "^5.6.2",
"commander": "^14.0.0",
"dotenv": "^17.2.3",
Expand Down
1 change: 1 addition & 0 deletions packages/blink/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
"@types/ws": "^8.18.1",
"@whatwg-node/server": "^0.10.12",
"@xterm/headless": "^5.5.0",
"ansi-escapes": "^7.1.1",
"chalk": "^5.6.2",
"commander": "^14.0.0",
"dotenv": "^17.2.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/blink/src/tui/components/text-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
KeypressProvider as KeypressProviderBase,
Config,
type InputPromptProps,
useBracketedPaste
useBracketedPaste,
} from "@jaaydenh/gemini-cli/ui";

function createMinimalConfig(): Config {
Expand Down
6 changes: 3 additions & 3 deletions packages/blink/src/tui/dev.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import React, {
useRef,
useState,
} from "react";
import { clearTerminal as clearTerminalEscape } from "ansi-escapes";
import { isToolApprovalOutput } from "../agent/tools";
import useDevMode, { type TokenUsage } from "../react/use-dev-mode";
import Markdown from "./components/markdown";
Expand Down Expand Up @@ -169,8 +170,7 @@ const Root = ({ directory }: { directory: string }) => {
const { write } = useStdout();
const [epoch, setEpoch] = useState(0);
const resetTerminal = useCallback(() => {
write("\x1Bc"); // Full terminal reset
write("\x1B[?25l"); // Hide cursor
write(clearTerminalEscape);
setEpoch((prev) => prev + 1);
}, [write]);

Expand Down Expand Up @@ -279,7 +279,7 @@ const Root = ({ directory }: { directory: string }) => {
</Box>
) : (
<Message
key={message.id}
key={`${message.id}-${index}`}
message={message}
previousMessage={
// These indices are off by one because of the banner's first message.
Expand Down