🤖 fix: Prevent unhandled promise rejection in web force delete #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Browser API was throwing on string errors while Electron returns error objects - This caused unhandled promise rejections when force delete failed in web mode - Added try-catch in useWorkspaceManagement for defensive error handling - Added comprehensive tests for browser API error handling behavior
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… .catch() The browser API now returns error objects matching Electron's behavior. Updated the only caller using .catch() to properly check result.success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using force delete in web/server mode, an unhandled promise rejection occurs, causing the error to be logged but not properly handled in the UI.
Root Cause: The browser API client's
invokeIPCfunction throws errors for string error messages, while Electron'sipcRenderer.invoke()returns error objects. This inconsistency meant that force delete errors in web mode were thrown as exceptions instead of being returned as{ success: false, error: '...' }.Solution
src/browser/api.tsto return error objects instead of throwing, matching Electron's behaviorremoveWorkspaceandrenameWorkspacein try-catch blocks for extra safety against network/parsing errorssrc/browser/api.test.tsto verify error handling behavior and prevent regressionsTesting
Generated with
cmux