🤖 Collapse WRITE DENIED errors by default #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File edit operations that fail with WRITE DENIED errors are common and expected (e.g., when a file is modified between read and write). These errors no longer warrant expanding the tool call by default. Changes: - FileEditToolCall now detects WRITE DENIED errors via prefix check - WRITE DENIED errors start collapsed (can still be manually expanded) - Other errors and successful edits remain expanded as before
Also updated AGENTS.md to remind future agents to search for existing constants before defining new ones.
ammario
approved these changes
Oct 24, 2025
Frontend cannot import from services/ due to import restrictions. Duplicated the constant in src/constants/ui.ts with a comment noting it must stay in sync with the backend definition.
Instead of duplicating the constant between backend (services/tools/fileCommon.ts) and frontend (constants/ui.ts), moved it to src/types/tools.ts which is already used as a shared location for tool-related types and constants. Updated all imports across: - Backend: file_edit_operation.ts, file_edit_insert.ts, file_edit_operation.test.ts - Frontend: FileEditToolCall.tsx - Removed duplicate from constants/ui.ts - Left comment in fileCommon.ts noting the move Also updated AGENTS.md with one sentence to prevent this class of mistake: when a constant exists in a layer-specific location but is needed across layers, move it to a shared location rather than duplicating it.
ammario
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
File edit tool calls that fail with
WRITE DENIEDerrors are displayed expanded by default. These errors happen frequently during normal operation (when a file is modified between read and write) and don't require immediate attention, making the expanded state noisy.Solution
Modified
FileEditToolCallto detectWRITE DENIEDerrors via prefix match and start them in collapsed state. Other errors and successful edits remain expanded as before.Users can still manually expand WRITE DENIED errors if they want to see the details.
Testing
Generated with
cmux