🤖 Allow interrupt (Ctrl+C) in ChatInput when no text selected #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
Ctrl+C(orCmd+Con Mac) to interrupt the stream only works when focus is outside editable elements. This means users cannot interrupt while ChatInput is focused, requiring them to click elsewhere first.Solution
Modified the interrupt handler in
useAIViewKeybindsto check for text selection:The logic now allows interrupt in editable elements as long as there's no active text selection, preventing conflict with the copy keybind.
Changes
useAIViewKeybinds.tsinterrupt handler to checkwindow.getSelection()Testing
Manual testing scenarios:
Generated with
cmux