Skip to content

fix(helm/provisioner): fail if psk and key are both set #15157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(helm/provisioner): fail if psk and key are both set #15157

merged 1 commit into from
Oct 22, 2024
+3 −143

Conversation

@johnstcn
Copy link
Member

@johnstcn johnstcn commented Oct 21, 2024 •
edited
Loading

Relates to #14985

Context: #15122 (comment)

Specifying both provisionerDaemon.pskSecretName and provisionerDaemon.keySecretName will now result in an error.

This prevents a potential CrashLoopBackoff debug session due to the following error:

error: cannot provide both provisioner key --key and pre-shared key --psk

@johnstcn johnstcn requested a review from spikecurtis October 21, 2024 11:29
@johnstcn johnstcn self-assigned this Oct 21, 2024
@johnstcn johnstcn merged commit c42f487 into main Oct 22, 2024
30 checks passed
@johnstcn johnstcn deleted the cj/helm-provisionerd-psk-and-key branch October 22, 2024 07:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@spikecurtis spikecurtis spikecurtis approved these changes

Assignees

@johnstcn johnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnstcn @spikecurtis