Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Conversation

@f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Sep 13, 2021

Todo:

  • Add feature flag flow steps

@f0ssel f0ssel changed the base branch from main to release-1.23 September 13, 2021 18:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2021

✨ Coder.com for PR #599 deployed! It will be updated on every commit.

@f0ssel f0ssel requested review from scsmithr and sreya September 13, 2021 19:16
@f0ssel f0ssel marked this pull request as ready for review September 13, 2021 21:01
@khorne3 khorne3 changed the base branch from release-1.23 to main September 14, 2021 18:20
@khorne3
Copy link
Contributor

khorne3 commented Sep 14, 2021

Hey @f0ssel, small change: we're targeting main for all our new docs so that they can be published and be linked to from the product. However, we don't want them shown, so in manifest.json features navigable which turns on/off whether the doc shows in the nav bar or not. The release branch will flip all navigable from false to true.

I realize this is a lot, so I'll be writing this up soon

@khorne3
Copy link
Contributor

khorne3 commented Sep 14, 2021

preview

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add steps to debug? I have a /coder/apps/config.yaml in my workspace but the icon isn't showing up.

@bpmct
Copy link
Member

bpmct commented Sep 20, 2021

Can you also add steps to debug? I have a /coder/apps/config.yaml in my workspace but the icon isn't showing up.

This was because the frontend wasn't merged yet, but I think we should still include some way to debug the generic apps, even if it's just an error in the console

Co-authored-by: Sean Smith <scsmithr@gmail.com>
@khorne3 khorne3 changed the base branch from main to release-1.23 September 22, 2021 14:05
@khorne3 khorne3 merged commit 85cb326 into release-1.23 Sep 22, 2021
@khorne3 khorne3 deleted the apps branch September 22, 2021 14:05
khorne3 pushed a commit that referenced this pull request Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants