Skip to content

chore(ci): exit 1 when make fmt is dirty #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021
Merged

chore(ci): exit 1 when make fmt is dirty #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9452b76
chore(ci): `exit 1` when `make fmt` is dirty
coadler Jun 29, 2021
9ca1caf
fixup! chore(ci): `exit 1` when `make fmt` is dirty
coadler Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ fmt: README.md
README.md: README.md.gotmpl values.yaml
@echo "--- Generating documentation"
helm-docs --template-files=$<
@echo "<!-- DO NOT EDIT. THIS IS GENERATED FROM README.md.gotmpl -->\n\n$$(cat README.md)" > README.md
@printf "<!-- DO NOT EDIT. THIS IS GENERATED FROM README.md.gotmpl -->\n\n%s\n" "$$(cat README.md)" > README.md
.PHONY: README.md

clean:
Expand Down
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,16 @@ View [our docs](https://coder.com/docs/setup/installation) for detailed installa
| postgres.host | string | Host of the external PostgreSQL instance. | `""` |
| postgres.passwordSecret | string | Name of an existing secret in the current namespace with the password of the PostgreSQL instance. The password must be contained in the secret field `password`. This should be set to an empty string if the database does not require a password to connect. | `""` |
| postgres.port | string | Port of the external PostgreSQL instance. | `""` |
| postgres.sslMode | string | Provides variable levels of protection for the PostgreSQL connection. For acceptable values, see: https://www.postgresql.org/docs/9.1/libpq-ssl.html | `"require"` |
| postgres.ssl | object | Options for configuring the SSL cert, key, and root cert when connecting to Postgres. | `{"certSecret":{"key":"","name":""},"keySecret":{"key":"","name":""},"rootCertSecret":{"key":"","name":""}}` |
| postgres.ssl.certSecret | object | Secret containing a PEM encoded cert file. | `{"key":"","name":""}` |
| postgres.ssl.certSecret.key | string | Key pointing to a certificate in the secret. | `""` |
| postgres.ssl.certSecret.name | string | Name of the secret. | `""` |
| postgres.ssl.keySecret | object | Secret containing a PEM encoded key file. | `{"key":"","name":""}` |
| postgres.ssl.keySecret.key | string | Key pointing to a certificate in the secret. | `""` |
| postgres.ssl.rootCertSecret | object | Secret containing a PEM encoded root cert file. | `{"key":"","name":""}` |
| postgres.ssl.rootCertSecret.key | string | Key pointing to a certificate in the secret. | `""` |
| postgres.ssl.rootCertSecret.name | string | Name of the secret. | `""` |
| postgres.sslMode | string | Provides variable levels of protection for the PostgreSQL connection. For acceptable values, see: https://www.postgresql.org/docs/11/libpq-ssl.html | `"require"` |
| postgres.user | string | User of the external PostgreSQL instance. | `""` |
| services | object | Kubernetes Service configuration that applies to Coder services. | `{"annotations":{},"clusterDomainSuffix":".svc.cluster.local","nodeSelector":{"kubernetes.io/arch":"amd64","kubernetes.io/os":"linux"},"tolerations":[],"type":"ClusterIP"}` |
| services.annotations | object | A KV mapping of annotations. See: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/ | `{}` |
Expand Down
2 changes: 2 additions & 0 deletions scripts/fmt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,7 @@ pushd "$PROJECT_ROOT" >/dev/null
do
git --no-pager diff "$file"
done

exit 1
fi
popd >/dev/null