Allow static NodePort #138
Conversation
| # coderd.serviceNodePorts -- Allows manually setting static node ports for the coderd service. | ||
| # This is only helpful if static ports are required, and usually should be left alone. | ||
| # By default these are dynamically chosen. | ||
| serviceNodePorts: |
There was a problem hiding this comment.
By adding these to the values file, these will be the default values applicable to all installs - is that what we want? What's the default behavior (e.g. if nodePort isn't specified)?
There was a problem hiding this comment.
The values.yaml is the default?
The original default is that the nodePorts are selected dynamically. I thought values.yaml was an example config for generating the docs.
There was a problem hiding this comment.
the values file is the defaults that will be used if you don't specify any that override them, it's included in the Helm chart package (so if you do: helm install . coder then it'll use the values.yaml file unmodified). otherwise, if you specify --set, then it'll merge the default values file with the args you pass
There was a problem hiding this comment.
TIL. So we can't document a field without explicitly setting a default?
I wonder if I can set it to null?
I prefer the default to be unset.
There was a problem hiding this comment.
I could also make the value "0" effectively be "unset"
There was a problem hiding this comment.
You can test by running make lint/kubernetes, this will generate a bunch of YAML files somewhere that you can examine
3 participants
What this does
We need this to get Kind to work for 1.21. It allows setting static nodeports