Separate ingress.usedefault from .enable #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows ingress.enabled to create the ingress object for use with another ingress controller. used in conjunction with coderd.serviceSpec.type=ClusterIP, coderd.devurlsHost, and ingress.host to get the full ingress experience
mterhar
commented
Jul 29, 2021
mterhar
commented
Jul 29, 2021
Contributor
Author
|
I'm not convinced that this isn't causing more trouble elsewhere. The useServiceNext mechanism seem to tie into making envproxy a thing and then the ingress gets all complicated again. I'm making these changes to support the istio deployment approach for Platform One so their helm chart is going to have some differences (as it always does) but I had hoped to bring that flexibility back to our chart. Once I get the platform one chart merged, i'll revisit this. |
mterhar
commented
Jul 29, 2021
Contributor
Author
|
May reset this branch and just remove the helm chart default values like "externalTrafficPolicy" and "loadBalancerIP" so they don't show up when someone sets |
Contributor
Author
|
fresh attempt in #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows ingress.enabled to create the ingress object for
use with another ingress controller.
used in conjunction with ingress.useDefault=false,
coderd.devurlsHost, and ingress.host to get the full ingress experience
Note that I tried setting coderd.serviceNext explicitly to false but it only looks for true. Not sure if we want that to be an either-way override or just a force-to-next or ignore mechanism as it is now.