Skip to content

Conversation

@f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Aug 3, 2021

No description provided.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can remove the entire Ingress object now too!

@deansheather
Copy link
Member

We can't remove the ingress object because it'll break customers that use cert-manager with ingress annotations, which the docs have recommended in the recent past

@f0ssel f0ssel merged commit 4541224 into main Aug 4, 2021
@f0ssel f0ssel deleted the remove-envproxy branch August 4, 2021 14:40
@jawnsy
Copy link

jawnsy commented Aug 4, 2021

We also need an ingress because LoadBalancer controllers are not a mandatory part of Kubernetes, so not every cluster has them. The clouds all have load balancer controllers but bare metal systems might not, which is why the MetalLB documentation says:

Kubernetes does not offer an implementation of network load balancers (Services of type LoadBalancer) for bare-metal clusters. The implementations of network load balancers that Kubernetes does ship with are all glue code that calls out to various IaaS platforms (GCP, AWS, Azure…). If you’re not running on a supported IaaS platform (GCP, AWS, Azure…), LoadBalancers will remain in the “pending” state indefinitely when created.

@f0ssel
Copy link
Contributor Author

f0ssel commented Aug 4, 2021

Yeah I think keeping an optional, dumb one is a happy medium

f0ssel added a commit that referenced this pull request Aug 5, 2021
* remove envproxy references from chart

* Fix cluster address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants