Skip to content

chore: set app label in coderd deployment #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2021
Merged

chore: set app label in coderd deployment #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9d7fe0
chore: set app label in coderd deployment
coadler Aug 9, 2021
ae2a6fe
add additional recommended labels
coadler Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions templates/coderd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ apiVersion: apps/v1
kind: Deployment
metadata:
labels:
app.kubernetes.io/name: {{ include "coder.serviceName" . }}
app.kubernetes.io/part-of: coder
app: {{ include "coder.serviceName" . }}
Copy link

@jawnsy jawnsy Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I wonder if it's related to https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Copy link
Contributor Author

@coadler coadler Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm maybe we should set some of these as well

Copy link

@jawnsy jawnsy Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Helm adds a bunch. Not a big deal, can always do it later!

coder.deployment: {{ include "coder.serviceName" . }}
name: {{ include "coder.serviceName" . }}
namespace: {{ .Release.Namespace | quote }}
Expand All @@ -22,6 +25,9 @@ spec:
template:
metadata:
labels:
app.kubernetes.io/name: {{ include "coder.serviceName" . }}
app.kubernetes.io/part-of: coder
app: {{ include "coder.serviceName" . }}
coder.deployment: {{ include "coder.serviceName" . }}
annotations:
{{- range $key, $value := fromYaml (include "movedValue" (dict "Values" .Values "Key" "services.annotations")) }}
Expand Down
4 changes: 4 additions & 0 deletions templates/timescale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ metadata:
name: timescale
namespace: {{ .Release.Namespace }}
labels:
app.kubernetes.io/name: timescale
app.kubernetes.io/part-of: coder
app: timescale
coder.deployment: timescale
spec:
Expand Down Expand Up @@ -34,6 +36,8 @@ spec:
template:
metadata:
labels:
app.kubernetes.io/name: timescale
app.kubernetes.io/part-of: coder
app: timescale
coder.deployment: timescale
annotations:
Expand Down