Skip to content

revert: "Load balancer TLS termination (#144)" #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021
Merged

revert: "Load balancer TLS termination (#144)" #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions templates/coderd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,22 +247,20 @@ spec:
selector:
coder.deployment: {{ include "coder.serviceName" . }}
ports:
- name: tcp-{{ include "coder.serviceName" . }}-https
port: 443
{{- if .Values.coderd.httpsToHttp }}¬
targetPort: 8443
protocol: TCP
{{ if .Values.coderd.serviceNodePorts.https }}
nodePort: {{ .Values.coderd.serviceNodePorts.https }}
{{ end }}
- name: tcp-{{ include "coder.serviceName" . }}
port: 80
{{- end }}
targetPort: 8080
protocol: TCP
{{ if .Values.coderd.serviceNodePorts.http }}
nodePort: {{ .Values.coderd.serviceNodePorts.http }}
{{ end }}
- name: tcp-{{ include "coder.serviceName" . }}-https
port: 443
targetPort: 8443
protocol: TCP
{{ if .Values.coderd.serviceNodePorts.https }}
nodePort: {{ .Values.coderd.serviceNodePorts.https }}
{{ end }}
{{- else }}
---
apiVersion: v1
Expand Down
5 changes: 0 additions & 5 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ coderd:
# coderd.serviceAnnotations -- Extra annotations to apply to the coderd service.
serviceAnnotations: {}

# coderd.httpsToHttp -- eliminates the external http port and routes traffic from
# the external https port to the internal http port. Useful for when the load balancer
# performs TLS termination (like Amazon's ACM)
httpsToHttp: false

# coderd.trustProxyIP -- Whether Coder should trust X-Real-IP and/or
# X-Forwarded-For headers from your reverse proxy. This should only be turned
# on if you're using a reverse proxy that sets both of these headers. This is
Expand Down