feat: Add amplitude key to helm chart #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
requested changes
Aug 27, 2021
values.yaml
Outdated
|
|
||
| # metrics -- Configure various metrics to gain observability into Coder. | ||
| metrics: | ||
| # metrics.amplitudeKey -- Enables telemetry pushing to Amplitude. Keep empty to disable |
Member
There was a problem hiding this comment.
We should add a link to Amplitude here, along with a bit of information with what specificially gets tracked. Is it anonymized?
Member
Author
There was a problem hiding this comment.
Will do. We will not store any PII.
We store ID's so it's not really anonymized, but it is pseudonymous.
Emyrk
commented
Aug 27, 2021
Comment on lines
+251
to
+258
| # metrics -- Configure various metrics to gain observability into Coder. | ||
| metrics: | ||
| # metrics.amplitudeKey -- Enables telemetry pushing to Amplitude. Amplitude records how users | ||
| # interact with Coder, which is used to improve the product. No events store any personal | ||
| # information. Amplitude can be found here: https://amplitude.com/ | ||
| # Keep empty to disable. | ||
| amplitudeKey: "" | ||
|
|
Member
Author
There was a problem hiding this comment.
@kylecarbs Better? I do not want to commit to "anonymized" data at this time. We can definitely fully anonymize data, but for SaaS we want some ways to indicate which deployment the data came from.
I think it'll be easier to draw some lines of where to fully anonymize and where not too once we have some data to play with.
kylecarbs
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Adds a
metricssection with theamplitudeKeyvalue to enable amplitude oncoderd.We will use a different key for master than SaaS, so using an env var makes sense.