Fix: port mismatch ingress to service #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 27, 2021 15:26
Ingress port needs to match the port number on the coderd service.
Contributor
Author
|
Swtiched to using the port name which is consistent whether the port number is 80 or 8080. Validation steps: helm pull coder/coder --version 1.23.0
tar zvfx coder-1.23.0.tgz
mv coder coder-1.23Replace the contents of templates/ingress.yaml kubectl create ns coder-ing-test
helm upgrade -i coder coder-1.23 -n coder-ing-test -f coder-1.23/examples/ingress/ingress.values.yamlI used coder.ing.terharlab.com to validate the connectivity and it worked just fine with the port name on K8s 1.20.9 in GCP. |
deansheather
approved these changes
Sep 27, 2021
deansheather
pushed a commit
that referenced
this pull request
Sep 29, 2021
* Fix: port mismatch ingress to service Ingress port needs to match the port on the service, switch the reference to port name (cherry picked from commit 61c230c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingress port needs to match the port number on the coderd service.
@deansheather This one.