Skip to content

feat: Strip devurl suffixs from input for host #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2021
Merged

feat: Strip devurl suffixs from input for host #173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3438705
Strip devurl suffixs
Emyrk Nov 17, 2021
86deff9
Add docs to regex
Emyrk Nov 17, 2021
9d7fa10
Add some comments
Emyrk Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,16 @@ spec:
name: {{ include "coder.serviceName" . }}
port:
name: tcp-{{ include "coder.serviceName" . }}
- host: {{ merge .Values dict | dig "coderd" "devurlsHost" "" | quote }}
{{ $devURLHost := merge .Values dict | dig "coderd" "devurlsHost" "" }}
# Regex docs on '*-suffix.example.com'. This is required as the original input including the suffix is
# not a legal ingress host. We need to remove the suffic, and keep the wildcard '*'.
# - '\\*' Starts with '*'
# - '[^.]*' Suffix is 0 or more characters, '-suffix'
# - '(' Start domain capture grp
# - '\\.' The domain should be separated with a '.' from the subdomain
# - '.*' Rest of the domain.
# - ')' $1 is the ''.example.com'
- host: {{ regexReplaceAll "\\*[^.]*(\\..*)" $devURLHost "*${1}" | quote }}
http:
paths:
- path: /
Expand Down