Skip to content

Conversation

@coadler
Copy link
Contributor

@coadler coadler commented Dec 8, 2021

No description provided.

@coadler coadler self-assigned this Dec 8, 2021
@coadler coadler force-pushed the colin/postgres-mtls branch 2 times, most recently from 2353fa7 to 44406e4 Compare December 8, 2021 18:55
sslMode: "require"
# postgres.ssl -- Options for configuring the SSL cert, key, and root cert
# when connecting to Postgres.
ssl:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about using tls here, makes things consistent with ingress.tls etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postgres always refers to it as SSL so I was staying consistent with their documentation and naming.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. alright I guess. I get why they need to call it SSL (backward compatibility) but since this is a new field for us, I prefer TLS. not a big deal to me though.

{{- else }}
{{- toYaml .Values.coderd.securityContext | nindent 12 }}
{{- end }}
{{- include "coder.volumeMounts" . | indent 10 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this work before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't need volume mounts before.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, I would've thought we'd need volume mounts for TLS certs and stuff 🤷‍♂️

@coadler coadler force-pushed the colin/postgres-mtls branch from 2a9dc31 to b952fba Compare December 8, 2021 21:15
@coadler coadler force-pushed the colin/postgres-mtls branch from b952fba to 6de6352 Compare December 8, 2021 21:21
@coadler coadler requested a review from jawnsy December 8, 2021 21:23
key: ""
# postgres.ssl.keySecret -- Secret containing a PEM encoded key file.
keySecret:
# postgres.ssl.keytSecret.name -- Name of the secret.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longer-term, we might want to consider an option to load this from a file in the certs directory (e.g. load the file into a Secret and use that secret name automatically)... but this is good for now

Copy link

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coadler coadler merged commit 3b423e3 into main Dec 8, 2021
@coadler coadler deleted the colin/postgres-mtls branch December 8, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants