-
Notifications
You must be signed in to change notification settings - Fork 17
feat: support postgres mtls #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2353fa7 to
44406e4
Compare
| sslMode: "require" | ||
| # postgres.ssl -- Options for configuring the SSL cert, key, and root cert | ||
| # when connecting to Postgres. | ||
| ssl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about using tls here, makes things consistent with ingress.tls etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postgres always refers to it as SSL so I was staying consistent with their documentation and naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm. alright I guess. I get why they need to call it SSL (backward compatibility) but since this is a new field for us, I prefer TLS. not a big deal to me though.
| {{- else }} | ||
| {{- toYaml .Values.coderd.securityContext | nindent 12 }} | ||
| {{- end }} | ||
| {{- include "coder.volumeMounts" . | indent 10 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It didn't need volume mounts before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, I would've thought we'd need volume mounts for TLS certs and stuff 🤷♂️
2a9dc31 to
b952fba
Compare
b952fba to
6de6352
Compare
| key: "" | ||
| # postgres.ssl.keySecret -- Secret containing a PEM encoded key file. | ||
| keySecret: | ||
| # postgres.ssl.keytSecret.name -- Name of the secret. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longer-term, we might want to consider an option to load this from a file in the certs directory (e.g. load the file into a Secret and use that secret name automatically)... but this is good for now
jawnsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.