Skip to content

Conversation

@jawnsy
Copy link

@jawnsy jawnsy commented Dec 10, 2021

  • Add coderd proxy settings for outbound connections
  • Move utility functions into separate file
  • Extract LoadChart out of TestDeployment tests to avoid repeatedly
    loading the chart for parallel tests
  • Refactor Render function to accept a function closure, as with
    MustRender, to make the function signatures more consistent
  • Add utility function to convert hard-coded environment variables
    into a map

Jonathan Yu added 2 commits December 10, 2021 22:38
* Add coderd proxy settings for outbound connections
* Move utility functions into separate file
* Extract LoadChart out of TestDeployment tests to avoid repeatedly
  loading the chart for parallel tests
* Refactor Render function to accept a function closure, as with
  MustRender, to make the function signatures more consistent
* Add utility function to convert hard-coded environment variables
  into a map
@jawnsy jawnsy self-assigned this Dec 10, 2021
@jawnsy jawnsy requested review from coadler, johnstcn and mterhar and removed request for coadler December 10, 2021 23:08
@jawnsy
Copy link
Author

jawnsy commented Dec 10, 2021

I tested this using an air-gapped installation. The cluster does not have external network access, and the only path to the Internet is a dual-homed host with a proxy installed.

Using the following values:

coderd:
  proxy:
    http: http://10.182.0.2:8888
    exempt: ghcr.io,cluster.local

I verified that:

  • In-cluster traffic works correctly (coderd can communicate with kubernetes API, which does not use the proxy)
  • Importing images from ghcr.io times out, since we try to connect directly and the system is air-gapped
  • Importing images from GCR works correctly (since images use the internal Private Google Access network)
  • Importing images from Docker Hub works correctly (they can be tracked by Coder, but not actually pulled, since the worker node is not configured to pull through the proxy)

[sc-19357]

@shortcut-integration
Copy link

@jawnsy jawnsy marked this pull request as ready for review December 10, 2021 23:15
@jawnsy jawnsy merged commit 179f92d into main Dec 10, 2021
@jawnsy jawnsy deleted the jawnsy/feat-proxy-settings branch December 10, 2021 23:28
@jawnsy
Copy link
Author

jawnsy commented Dec 10, 2021

For posterity, this article surveys the different environment variable options and how they work: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants