Skip to content

feat: test coverage for services.annotations #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 16, 2022
Merged

feat: test coverage for services.annotations #217

merged 17 commits into from
Feb 16, 2022

Conversation

@ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Jan 28, 2022 •
edited
Loading

unit test for the services.annotations value.

@ericpaulsen ericpaulsen added enhancement New feature or request go Pull requests that update Go code labels Jan 28, 2022
@ericpaulsen ericpaulsen requested a review from jawnsy January 28, 2022 00:48
@ericpaulsen ericpaulsen self-assigned this Jan 28, 2022
jawnsy
jawnsy reviewed Jan 28, 2022
View reviewed changes
@jawnsy jawnsy requested a review from deansheather January 28, 2022 01:39
ericpaulsen
ericpaulsen commented Feb 4, 2022
View reviewed changes
ericpaulsen
ericpaulsen commented Feb 4, 2022
View reviewed changes
deansheather
deansheather reviewed Feb 4, 2022
View reviewed changes
jawnsy
jawnsy reviewed Feb 4, 2022
View reviewed changes
@deansheather deansheather requested a review from jawnsy February 5, 2022 01:06
@ericpaulsen
Copy link
Member Author

ericpaulsen commented Feb 9, 2022 •
edited
Loading

@deansheather @jawnsy - I may have got myself into a figurative git hairball trying to resolve conflicts. let me know when you have some time to assist.

jawnsy
jawnsy reviewed Feb 9, 2022
View reviewed changes
jawnsy
jawnsy reviewed Feb 10, 2022
View reviewed changes
jawnsy
jawnsy reviewed Feb 11, 2022
View reviewed changes
jawnsy
jawnsy reviewed Feb 11, 2022
View reviewed changes
jawnsy
jawnsy reviewed Feb 11, 2022
View reviewed changes
jawnsy
jawnsy approved these changes Feb 16, 2022
View reviewed changes
Copy link

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpaulsen ericpaulsen merged commit 60df5e3 into main Feb 16, 2022
@ericpaulsen ericpaulsen deleted the ericpaulsen/annotation-test branch February 16, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deansheather deansheather deansheather approved these changes

+1 more reviewer

@jawnsy jawnsy jawnsy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ericpaulsen ericpaulsen

Labels

enhancement New feature or request go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ericpaulsen @jawnsy @deansheather