Skip to content

fix: bunch of bugs related to text highlighting #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sreya merged 11 commits into from
Nov 25, 2025
Merged

fix: bunch of bugs related to text highlighting #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6d84693
fix: selection highlight persisting and add auto-scroll during drag s…
sreya Nov 25, 2025
619b563
fix: preserve selection during data writes and clarify scroll direction
sreya Nov 25, 2025
1b70ef4
fix: prevent click handler from clearing selection after drag ends
sreya Nov 25, 2025
cfcc876
fix: track mousedown target instead of using setTimeout
sreya Nov 25, 2025
605e3ad
fix: use absolute buffer coordinates for selection
sreya Nov 25, 2025
894208d
fix: clamp selection viewport coordinates to visible range
sreya Nov 25, 2025
2515284
fix: extend selection during auto-scroll instead of resetting
sreya Nov 25, 2025
9468ca8
fix: don't update selectionEnd from mousemove during auto-scroll
sreya Nov 25, 2025
ef8b3bb
fix: correct viewport-to-absolute row conversion formula
sreya Nov 25, 2025
8f5a89a
fix: getSelection() now uses absolute coordinates to fetch all select…
sreya Nov 25, 2025
40fb5d9
test: add comprehensive selection manager tests
sreya Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,15 +308,15 @@ export class CanvasRenderer {
}
}

// Always mark previous selection rows for redraw (to clear old overlay)
// Always mark dirty selection rows for redraw (to clear old overlay)
if (this.selectionManager) {
const prevCoords = this.selectionManager.getPreviousSelectionCoords();
if (prevCoords) {
for (let row = prevCoords.startRow; row <= prevCoords.endRow; row++) {
const dirtyRows = this.selectionManager.getDirtySelectionRows();
if (dirtyRows.size > 0) {
for (const row of dirtyRows) {
selectionRows.add(row);
}
// Clear the previous selection tracking after marking for redraw
this.selectionManager.clearPreviousSelection();
// Clear the dirty rows tracking after marking for redraw
this.selectionManager.clearDirtySelectionRows();
}
}

Expand Down
Loading