Skip to content

chore: remove unused JIRA sender #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jawnsy merged 1 commit into from
Feb 14, 2022
Merged

chore: remove unused JIRA sender #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ Grip supports a number of different logging output backends:
- writing messages to a file.
- sending messages to a slack's channel
- sending messages to a user via XMPP (jabber.)
- creating or commeting on a jira ticket
- creating or commenting on a github issue
- sending a desktop notification
- sending an email.
- sending log output.
Expand Down
36 changes: 0 additions & 36 deletions message/composer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ func TestPopulatedMessageComposerConstructors(t *testing.T) {
NewLineMessage(level.Error, testMsg): testMsg,
MakeGroupComposer(NewString(testMsg)): testMsg,
NewGroupComposer([]Composer{NewString(testMsg)}): testMsg,
MakeJiraMessage(&JiraIssue{Summary: testMsg, Type: "Something"}): testMsg,
NewJiraMessage("", testMsg, JiraField{Key: "type", Value: "Something"}): testMsg,
NewFieldsMessage(level.Error, testMsg, Fields{}): fmt.Sprintf("[message='%s']", testMsg),
NewFields(level.Error, Fields{"test": testMsg}): fmt.Sprintf("[test='%s']", testMsg),
MakeFieldsMessage(testMsg, Fields{}): fmt.Sprintf("[message='%s']", testMsg),
Expand All @@ -58,7 +56,6 @@ func TestPopulatedMessageComposerConstructors(t *testing.T) {
Subject: "Test msg",
Body: testMsg,
}): fmt.Sprintf("To: someone@example.com; Body: %s", testMsg),
NewJIRACommentMessage(level.Error, "ABC-123", testMsg): testMsg,
NewSlackMessage(level.Error, "@someone", testMsg, nil): fmt.Sprintf("@someone: %s", testMsg),
}

Expand Down Expand Up @@ -125,7 +122,6 @@ func TestUnpopulatedMessageComposers(t *testing.T) {
Whenf(false, "", ""),
Whenln(false, "", ""),
NewEmailMessage(level.Error, Email{}),
NewJIRACommentMessage(level.Error, "", ""),
NewSlackMessage(level.Error, "", "", nil),
MakeComposerProducerMessage(nil),
MakeComposerProducerMessage(func() Composer { return nil }),
Expand Down Expand Up @@ -363,26 +359,6 @@ func TestComposerConverter(t *testing.T) {

}

func TestJiraMessageComposerConstructor(t *testing.T) {
const testMsg = "hello"
assert := assert.New(t) // nolint
reporterField := JiraField{Key: "Reporter", Value: "Annie"}
assigneeField := JiraField{Key: "Assignee", Value: "Sejin"}
typeField := JiraField{Key: "Type", Value: "Bug"}
labelsField := JiraField{Key: "Labels", Value: []string{"Soul", "Pop"}}
unknownField := JiraField{Key: "Artist", Value: "Adele"}
msg := NewJiraMessage("project", testMsg, reporterField, assigneeField, typeField, labelsField, unknownField)
issue := msg.Raw().(*JiraIssue)

assert.Equal(issue.Project, "project")
assert.Equal(issue.Summary, testMsg)
assert.Equal(issue.Reporter, reporterField.Value)
assert.Equal(issue.Assignee, assigneeField.Value)
assert.Equal(issue.Type, typeField.Value)
assert.Equal(issue.Labels, labelsField.Value)
assert.Equal(issue.Fields[unknownField.Key], unknownField.Value)
}

func TestProcessTreeDoesNotHaveDuplicates(t *testing.T) {
assert := assert.New(t) // nolint

Expand All @@ -398,18 +374,6 @@ func TestProcessTreeDoesNotHaveDuplicates(t *testing.T) {
assert.Equal(len(seen), len(procs))
}

func TestJiraIssueAnnotationOnlySupportsStrings(t *testing.T) {
assert := assert.New(t) // nolint

m := &jiraMessage{
issue: &JiraIssue{},
}

assert.Error(m.Annotate("k", 1))
assert.Error(m.Annotate("k", true))
assert.Error(m.Annotate("k", nil))
}

type causer interface {
Cause() error
}
Expand Down
4 changes: 0 additions & 4 deletions message/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,6 @@ func IsStructured(msg Composer) bool {
return true
case *GoRuntimeInfo:
return true
case *jiraMessage:
return true
case *jiraComment:
return false
case *errorMessage:
return true
case *emailMessage:
Expand Down
51 changes: 0 additions & 51 deletions message/jira_comment.go
View file
Open in desktop

This file was deleted.

104 changes: 0 additions & 104 deletions message/jira_issue.go
View file
Open in desktop

This file was deleted.