Commit 5d5ce0a
authored
🤖 Fix: Remove unnecessary DMG signing and split artifacts (#85)
## Problem
1. PR #83 added `dmg.sign: true` which is actually **unnecessary and
discouraged** by electron-builder
2. Both DMG files (x64 and arm64) are being uploaded as a single
artifact, making it confusing for users
## Solution
1. **Removed `dmg.sign: true`** - DMG signing is not needed and can
cause issues. What matters is the .app bundle signing (which works
perfectly)
2. **Split artifacts** - Now uploading as separate `macos-dmg-x64` and
`macos-dmg-arm64` artifacts for clarity
## Why DMG signing is unnecessary
According to electron-builder documentation: "Signing is not required
and will lead to unwanted errors in combination with notarization
requirements."
The .app bundle inside the DMG is properly signed with:
- Developer ID Application certificate
- Hardened Runtime enabled
- All frameworks and helpers signed
- Valid certificate chain through Apple Root CA
✅ Verified on local machine: `codesign --verify --deep --strict` passes
## Changes
```yaml
# .github/workflows/build.yml
- name: Upload macOS DMG (x64)
path: release/*-x64.dmg
- name: Upload macOS DMG (arm64)
path: release/*-arm64.dmg
```
```json
// package.json - removed dmg section entirely
"mac": {
"target": [
{ "target": "dmg", "arch": "x64" },
{ "target": "dmg", "arch": "arm64" }
],
...
}
```
_Generated with `cmux`_1 parent f3cc163 commit 5d5ce0a
2 files changed
+11
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
44 | 52 | | |
45 | 53 | | |
46 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | 121 | | |
125 | 122 | | |
126 | 123 | | |
| |||
0 commit comments