Skip to content

Commit 5d5ce0a

Browse files
authored
🤖 Fix: Remove unnecessary DMG signing and split artifacts (#85)
## Problem 1. PR #83 added `dmg.sign: true` which is actually **unnecessary and discouraged** by electron-builder 2. Both DMG files (x64 and arm64) are being uploaded as a single artifact, making it confusing for users ## Solution 1. **Removed `dmg.sign: true`** - DMG signing is not needed and can cause issues. What matters is the .app bundle signing (which works perfectly) 2. **Split artifacts** - Now uploading as separate `macos-dmg-x64` and `macos-dmg-arm64` artifacts for clarity ## Why DMG signing is unnecessary According to electron-builder documentation: "Signing is not required and will lead to unwanted errors in combination with notarization requirements." The .app bundle inside the DMG is properly signed with: - Developer ID Application certificate - Hardened Runtime enabled - All frameworks and helpers signed - Valid certificate chain through Apple Root CA ✅ Verified on local machine: `codesign --verify --deep --strict` passes ## Changes ```yaml # .github/workflows/build.yml - name: Upload macOS DMG (x64) path: release/*-x64.dmg - name: Upload macOS DMG (arm64) path: release/*-arm64.dmg ``` ```json // package.json - removed dmg section entirely "mac": { "target": [ { "target": "dmg", "arch": "x64" }, { "target": "dmg", "arch": "arm64" } ], ... } ``` _Generated with `cmux`_
1 parent f3cc163 commit 5d5ce0a

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

.github/workflows/build.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,19 @@ jobs:
3636
fi
3737
bun run dist:mac
3838
39-
- name: Upload macOS DMG
39+
- name: Upload macOS DMG (x64)
4040
uses: actions/upload-artifact@v4
4141
with:
42-
name: macos-dmg
43-
path: release/*.dmg
42+
name: macos-dmg-x64
43+
path: release/*-x64.dmg
44+
retention-days: 30
45+
if-no-files-found: error
46+
47+
- name: Upload macOS DMG (arm64)
48+
uses: actions/upload-artifact@v4
49+
with:
50+
name: macos-dmg-arm64
51+
path: release/*-arm64.dmg
4452
retention-days: 30
4553
if-no-files-found: error
4654

package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@
118118
"entitlements": "build/entitlements.mac.plist",
119119
"entitlementsInherit": "build/entitlements.mac.plist"
120120
},
121-
"dmg": {
122-
"sign": true
123-
},
124121
"linux": {
125122
"target": "AppImage",
126123
"category": "Development",

0 commit comments

Comments
 (0)