🤖 Make 1M context setting global instead of per-workspace #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change use1MContext hook to use global localStorage instead of per-workspace. The 1M context setting now applies to all workspaces. Changes: - Remove workspaceId parameter from use1MContext hook - Update all call sites to not pass workspaceId - Remove workspaceId from ChatContext (no longer needed) - Update ChatProvider in AIView to not require workspaceId This simplifies the UX - users either want 1M context or they don't, regardless of which workspace they're in.
Script now fails early if PR is closed (not merged), preventing infinite waiting on closed PRs.
ammar-agent
force-pushed
the
make-1m-context-global
branch
from
479aff4 to
ad66469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the 1M context checkbox setting global instead of per-workspace.
Changes
use1MContexthook to use global localStorage keyworkspaceIdparameter from hook signatureworkspaceIdfrom ChatContext (no longer needed)wait_pr_checks.shscriptRationale
Users typically want 1M context either on or off everywhere. Per-workspace state caused confusion when switching between workspaces.
Testing
Generated with
cmux