🤖 Fix: fmt-check silently passing + add screenshot script #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
fmt-checkwas silently passing even with unformatted codeprettier --checkthroughgrep -v 'No files matching'No convenient workflow for adding screenshots to docs
Solutions
Fixed fmt-check exit code handling:
Added
scripts/quick-cp-screenshot.sh:~/Documents/Screenshotsor~/Desktopcwebp -q 85(as lint requires)docs/img/<name>.webpUsage:
./scripts/quick-cp-screenshot.sh my-featureFormatted previously unformatted files:
vim.ts,vim.test.ts(from PR 🤖 Fix: Vim 'e' motion and add '_' motion #116)vim-mode.md(underscore escaping)context-management.md(existing edits from main)These files were already unformatted in main because fmt-check was passing incorrectly.
Verification
make fmt-checknow properly fails when files need formatting:Generated with
cmux