🤖 Fix fmt/fmt-check parity with clean Makefile design #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - make fmt and make fmt-check had different behaviors - Different patterns in Makefile vs scripts/fmt.sh - make fmt only formatted Prettier files - make fmt-check checked Prettier + Nix (but not shell) - No single source of truth Solution: Created fmt.mk with centralized formatting logic that guarantees parity between format and check commands. Changes: - Add fmt.mk: All formatting rules with single source of truth - Update Makefile: Include fmt.mk, remove duplicate logic - Format shell scripts: Apply shfmt formatting Design: - make fmt runs: fmt-prettier + fmt-shell + fmt-nix - make fmt-check runs: fmt-prettier-check + fmt-shell-check + fmt-nix-check - Same patterns, same tools, guaranteed parity Benefits: - Parity by construction (both use same underlying targets) - Idiomatic Make (standard include mechanism) - Composable (can run individual formatters) - Maintainable (all logic in one place)
Uses the version specified in package.json rather than any globally installed version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
make fmtandmake fmt-checkhad different behaviors:make fmtonly ran Prettier,make fmt-checkran Prettier + Nix + shellSolution
Created
fmt.mkthat centralizes all formatting logic:make fmt→fmt-prettier+fmt-shell+fmt-nixmake fmt-check→fmt-prettier-check+fmt-shell-check+fmt-nix-checkBoth use the same patterns and tools, guaranteed parity by construction.
Changes
fmt.mk: All formatting rules in one placeMakefile: Includefmt.mk, remove duplicate logicbun x prettierfor reproducibilityGenerated with
cmux