🤖 Fix Ctrl+J/K workspace navigation to use sorted order #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigation now follows visual order displayed in sidebar. **Problem:** - PR #205 added recency-based sorting to workspace display - Ctrl+J/K navigation still used unsorted config order - Caused confusion: pressing next didn't select next visible workspace **Solution:** - Move sorting logic from ProjectSidebar to App.tsx - Share sorted list between navigation and display - Both now use same recency-sorted order **Changes:** - Added sortedWorkspacesByProject memo in App.tsx - Updated handleNavigateWorkspace to use sorted list - Pass sorted list through LeftSidebar to ProjectSidebar - Remove duplicate sorting logic from ProjectSidebar
Now that sorting is done in App.tsx, ProjectSidebar no longer needs the workspaceRecency prop - it just receives the pre-sorted list.
ammario
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace navigation (Ctrl+J/K) now follows the visual order displayed in the sidebar.
Problem
PR #205 added recency-based sorting to the workspace display, but Ctrl+J/K navigation still used the unsorted config order. This caused confusion where pressing "next workspace" wouldn't select the next visible workspace in the sidebar.
Solution
Moved the sorting logic from ProjectSidebar to App.tsx so both navigation and display use the same recency-sorted workspace list. This ensures Ctrl+J/K navigation matches the visual order users see.
Changes
sortedWorkspacesByProjectmemo in App.tsx that sorts workspaces by recencyhandleNavigateWorkspaceto use the sorted list instead of raw config orderTesting
Generated with
cmux